Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/stable latest #1046

Merged
merged 26 commits into from
Jan 23, 2025
Merged

Fix/stable latest #1046

merged 26 commits into from
Jan 23, 2025

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Jan 22, 2025

Context: This PR introduces a temporary fix, for a deprecation problem in Lightning tests.
We also fixed some typos, broke down tests in Pennylane and Pennylane-Lightning distinct steps where sensible, and reduced the number of shots in PennyLane from 20K to 10K (fingers crossed).

[sc-82829]

stable/latest
Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.39%. Comparing base (290c986) to head (29c5218).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (290c986) and HEAD (29c5218). Click for more details.

HEAD has 129 uploads less than BASE
Flag BASE (290c986) HEAD (29c5218)
141 12
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1046       +/-   ##
===========================================
- Coverage   98.10%   84.39%   -13.72%     
===========================================
  Files         233       29      -204     
  Lines       39079     2646    -36433     
===========================================
- Hits        38339     2233    -36106     
+ Misses        740      413      -327     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmintorDusko AmintorDusko marked this pull request as ready for review January 22, 2025 20:10
@AmintorDusko AmintorDusko requested review from a team and JerryChen97 January 22, 2025 20:30
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @AmintorDusko 🙌

Copy link
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JerryChen97
Copy link
Contributor

JerryChen97 commented Jan 22, 2025

@AmintorDusko Another thing out of the current scope but perhaps related to the primary goal of this PR is: the on-going deprecation on ControlledQubitUnitary input arg control_wires and QubitUnitary type base may also introduce new breakdowns to stable-Lightning/latest-PennyLane test matrix...
PennyLaneAI/pennylane#6839

@AmintorDusko
Copy link
Contributor Author

@AmintorDusko Another thing out of the current scope but perhaps related to the primary goal of this PR is: the on-going deprecation on ControlledQubitUnitary input arg control_wires and QubitUnitary type base may also introduce new breakdowns to stable-Lightning/latest-PennyLane test matrix... PennyLaneAI/pennylane#6839

I will keep an eye on this. Thanks you so much!

@AmintorDusko
Copy link
Contributor Author

I'm re-running the tests as I found a problem there.
The link is already up-to-date.
Feel free to merge this PR if the tests are successful, and the PR double approved.

@josephleekl
Copy link
Contributor

josephleekl commented Jan 23, 2025

Thanks @AmintorDusko! Just wondering should we update to cover the deprecation for this PR too? The corresponding Pennylane PR has been merged, so this will fail the stable/latest again...

@AmintorDusko
Copy link
Contributor Author

Sorry @JerryChen97, I re-tagged you by mistake.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AmintorDusko! 🙌

@AmintorDusko AmintorDusko merged commit 25e6517 into master Jan 23, 2025
105 of 106 checks passed
@AmintorDusko AmintorDusko deleted the fix/stable-latest branch January 23, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants