-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/stable latest #1046
Fix/stable latest #1046
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1046 +/- ##
===========================================
- Coverage 98.10% 84.39% -13.72%
===========================================
Files 233 29 -204
Lines 39079 2646 -36433
===========================================
- Hits 38339 2233 -36106
+ Misses 740 413 -327 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Yushao Chen (Jerry) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks @AmintorDusko 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
@AmintorDusko Another thing out of the current scope but perhaps related to the primary goal of this PR is: the on-going deprecation on |
I will keep an eye on this. Thanks you so much! |
I'm re-running the tests as I found a problem there. |
Thanks @AmintorDusko! Just wondering should we update to cover the deprecation for this PR too? The corresponding Pennylane PR has been merged, so this will fail the stable/latest again... |
Sorry @JerryChen97, I re-tagged you by mistake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AmintorDusko! 🙌
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Context: This PR introduces a temporary fix, for a deprecation problem in Lightning tests.
We also fixed some typos, broke down tests in Pennylane and Pennylane-Lightning distinct steps where sensible, and reduced the number of shots in PennyLane from 20K to 10K (fingers crossed).
[sc-82829]
stable/latest
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: