-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade minimum required version of Pennylane to v0.40 #1033
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1033 +/- ##
===========================================
- Coverage 38.90% 27.36% -11.55%
===========================================
Files 48 29 -19
Lines 3177 2646 -531
===========================================
- Hits 1236 724 -512
+ Misses 1941 1922 -19 ☔ View full report in Codecov by Sentry. |
Thanks @josephleekl. Don't forget to change the version from rc{n} to rc{n+1}. |
@josephleekl could you please get this PR updated with the latest master branch? Looks like we have to get this PR merged ASAP. CC: @maliasadi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @josephleekl for taking care of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Co-authored-by: Ali Asadi <[email protected]>
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Pennylane Lightning v0.40 is not compatible with Pennylane version <0.40. This PR upgrades the pennylane requirement.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-82212]