Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade minimum required version of Pennylane to v0.40 #1033

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Jan 9, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Pennylane Lightning v0.40 is not compatible with Pennylane version <0.40. This PR upgrades the pennylane requirement.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-82212]

@josephleekl josephleekl added the do not merge Do not merge PR until this label is removed label Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.36%. Comparing base (b87e87e) to head (4280d52).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pennylane_lightning/core/lightning_base.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b87e87e) and HEAD (4280d52). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (b87e87e) HEAD (4280d52)
9 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1033       +/-   ##
===========================================
- Coverage   38.90%   27.36%   -11.55%     
===========================================
  Files          48       29       -19     
  Lines        3177     2646      -531     
===========================================
- Hits         1236      724      -512     
+ Misses       1941     1922       -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multiphaseCFD
Copy link
Member

Thanks @josephleekl. Don't forget to change the version from rc{n} to rc{n+1}.

@multiphaseCFD multiphaseCFD added the urgent Mark a pull request as high priority label Jan 9, 2025
@josephleekl josephleekl removed the urgent Mark a pull request as high priority label Jan 10, 2025
@multiphaseCFD multiphaseCFD changed the base branch from v0.40.0_rc to master January 10, 2025 14:46
@multiphaseCFD
Copy link
Member

@josephleekl could you please get this PR updated with the latest master branch? Looks like we have to get this PR merged ASAP. CC: @maliasadi

@josephleekl josephleekl marked this pull request as ready for review January 15, 2025 15:12
@josephleekl josephleekl added ci:build_wheels Activate wheel building. and removed do not merge Do not merge PR until this label is removed labels Jan 15, 2025
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @josephleekl for taking care of it.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@josephleekl josephleekl changed the title bump pennylane requirement to v0.40 Upgrade minimum required version of Pennylane to v0.40 Jan 15, 2025
@josephleekl josephleekl merged commit 4dec147 into master Jan 15, 2025
91 of 92 checks passed
@josephleekl josephleekl deleted the upgrade-PL-requirement branch January 15, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants