-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the RTLD_NODELETE flag to dlopen #1030
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1030 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 178 178
Lines 27450 27450
=======================================
Hits 25265 25265
Misses 2185 2185 ☔ View full report in Codecov by Sentry. |
I think the current issue only appears when running finite-shot hermitians, so not necessarily related to the original problem found with Shor. |
Thanks @dime10 for the updates! Just updated the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Not sure how you guys handle it but I often leave comments in the code for why a tweak like this was necessary to help future developers.
Good point. Comments added. Thanks @dime10 |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
There are segfault issue for finite-shot hermitians tests with Catalyst on arm64-macos. It looks like closing
libscipy_openblas.dylib
has a side effect that leads to the segfault and usingRTLD_NODELETE
mitigates that.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-80901]