-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macos rpath fix #1029
Macos rpath fix #1029
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1029 +/- ##
===========================================
- Coverage 94.34% 27.45% -66.89%
===========================================
Files 233 29 -204
Lines 39003 2637 -36366
===========================================
- Hits 36796 724 -36072
+ Misses 2207 1913 -294 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this fixed the discovery of the library on macos, so let's merge it regardless 👍
Context:
@loader_path
instead of$ORIGIN
would work forrpath
setting fromCMake
inmacos
.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-80803]