Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macos rpath fix #1029

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Macos rpath fix #1029

merged 5 commits into from
Dec 18, 2024

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Dec 17, 2024

Context:

@loader_path instead of $ORIGIN would work for rpath setting from CMake in macos.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-80803]

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.45%. Comparing base (4ddcdf2) to head (c2487b5).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4ddcdf2) and HEAD (c2487b5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4ddcdf2) HEAD (c2487b5)
7 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1029       +/-   ##
===========================================
- Coverage   94.34%   27.45%   -66.89%     
===========================================
  Files         233       29      -204     
  Lines       39003     2637    -36366     
===========================================
- Hits        36796      724    -36072     
+ Misses       2207     1913      -294     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fixed the discovery of the library on macos, so let's merge it regardless 👍

@multiphaseCFD multiphaseCFD marked this pull request as ready for review December 18, 2024 16:34
@multiphaseCFD multiphaseCFD merged commit 42d3b8e into master Dec 18, 2024
108 of 117 checks passed
@multiphaseCFD multiphaseCFD deleted the fix_macos_rpath branch December 18, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants