Upgrade LK/LGPU CI tests to use cuda 12.4 #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1023 +/- ##
==========================================
- Coverage 96.75% 92.42% -4.33%
==========================================
Files 233 112 -121
Lines 39910 16923 -22987
==========================================
- Hits 38614 15641 -22973
+ Misses 1296 1282 -14 ☔ View full report in Codecov by Sentry. |
josephleekl
changed the title
josephleekl
added
ci:use-gpu-runner
josephleekl
added
ci:build_wheels
AmintorDusko
approved these changes
Dec 13, 2024
Before merging could you please run, stable/stable and latest/latest? |
Thanks Amintor! I'll update the latest/latest workflow to check this, as well as run the stable/stable |
maliasadi
approved these changes
Dec 13, 2024
Co-authored-by: Ali Asadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Lightning Kokkos CUDA C++ tests fail to compile due to bug with CUDA 12.2 + Catch2. CI instance is now upgraded to CUDA 12.4, and all GPU CI tests ([LK, LGPU/LTensor]x[C++, Python]) need to be updated to load CUDA 12.4.
Description of the Change:
Update github workflow to load CUDA 12.4. Also change Lightning Kokkos C++ test to use
Releasebuild instead ofRelWithDebInfodue to segmentation fault when combined with coverage collection. The relevant test and line is here.Benefits:
Will be able to run Lightning Kokkos C++ tests with CUDA.
Possible Drawbacks:
Related GitHub Issues:
[sc-80288]