Fix Lightning GPU Rot adjoint bug and enable Rot in toml #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1004 +/- ##
==========================================
+ Coverage 95.80% 96.42% +0.61%
==========================================
Files 228 138 -90
Lines 35803 21785 -14018
==========================================
- Hits 34301 21006 -13295
+ Misses 1502 779 -723 ☔ View full report in Codecov by Sentry. |
josephleekl
added
ci:use-multi-gpu-runner
josephleekl
requested review from
maliasadi,
multiphaseCFD,
LuisAlfredoNu and
AmintorDusko
|
Do you think that we need to change something in the Python test to prevent this error again? 🤔 |
maliasadi
approved these changes
Nov 22, 2024
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp
Outdated
Show resolved
Hide resolved
multiphaseCFD
approved these changes
Nov 25, 2024
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp
Outdated
Show resolved
Hide resolved
maliasadi
reviewed
Nov 25, 2024
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaMPI.hpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Previously the implementation of Rot and CRot gates (e.g.
Rot(a, b, c)) with adjoint in LGPU ended up multiplyingRot(-a, -b, -c)instead ofRot(-c, -b, -a). The error was not found in tests since the C++ tests used the wrong adjoint rotation matrix, and sinceAdjoint(Rot)andAdjoint(CRot)were not in the frozenset, they were not executed in the Python tests. The error is found when adding the invertible capability for Rot and CRot and the following test fails.Description of the Change:
This PR fixes the implementation and C++ tests. The toml file is also updated to enable
Adjoint(Rot)andAdjoint(CRot)from Python.Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-78931]