Skip to content
This repository was archived by the owner on Feb 5, 2024. It is now read-only.

Avoid unsupported probs with out of order wires #94

Merged
merged 9 commits into from
Feb 21, 2023
Merged

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Feb 21, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: This PR follows the same support for lightning PR PennyLaneAI/pennylane-lightning#416 and prevents out of order wires being supplied directly to probs.

Description of the Change: As above.

Benefits: Prevents incorrect results being returned to user, and fails early instead.

Possible Drawbacks:

Related GitHub Issues: PennyLaneAI/pennylane-lightning#416

@github-actions
Copy link

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@mlxd mlxd marked this pull request as ready for review February 21, 2023 19:11
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that!
Remember to add an entry to the changelog.

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlxd for the nice work!

@mlxd mlxd merged commit ea83d49 into main Feb 21, 2023
@vincentmr vincentmr deleted the fix_wire_order branch April 25, 2023 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants