[Frontend] Split non-commuting observables #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-60186] |
lillian542
added a commit
to PennyLaneAI/pennylane-lightning
that referenced
this pull request
Jun 18, 2024
**Context:** Catalyst is adding `non_commuting_observables` as a flag in the TOML file, and conditionally applying the `split_non_commuting` transform in the QJIT device preprocessing if the backend doesn't allow non-commuting observables. **Description of the Change:** Update the lightning TOML files to indicate that non-commuting observables are supported. **Benefits:** Lightning stays consistent with the changes in [this PR](PennyLaneAI/catalyst#821) --------- Co-authored-by: ringo-but-quantum <[email protected]>
lillian542
commented
Jun 18, 2024
|
Hello. You may have forgotten to update the changelog!
|
lillian542
commented
Jun 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
=======================================
Coverage 97.95% 97.96%
=======================================
Files 71 71
Lines 10244 10248 +4
Branches 902 903 +1
=======================================
+ Hits 10035 10039 +4
Misses 167 167
Partials 42 42 ☔ View full report in Codecov by Sentry. |
lillian542
changed the title
lillian542
commented
Jun 19, 2024
erick-xanadu
approved these changes
Jun 19, 2024
lillian542
commented
Jun 19, 2024
… into split-non-commuting
|
Edit: wrong story ID |
|
[sc-60188] |
|
Did we add the flag to lightning as well? :) |
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
State-based simulators can generally get the values for non-commuting observables together on a single execution. Hardware and some simulators require non-commuting observables to be separated into different executions.
Description of the Change:
We add a
non_commuting_observablesflag to the TOML file. IfTrue, the device can deal with non-commuting observables.We check the
non_commuting_observables_flagindevice.preprocess, and add thesplit_non_commutingtransform to the transform_program if it'sFalse.