-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Pass capabilities to the decomposer #749
Conversation
…sing-capabilities
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
==========================================
- Coverage 98.07% 98.06% -0.01%
==========================================
Files 70 69 -1
Lines 9601 9512 -89
Branches 756 756
==========================================
- Hits 9416 9328 -88
+ Misses 151 150 -1
Partials 34 34 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a few minor comments.
Hello. You may have forgotten to update the changelog!
|
…sing-capabilities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Context: Catalyst needs to deal with operations which are not supported by the target device. This PR addresses decomposition-to-matrix branch.
Description of the Change: We read gates to be decomposed to matrix from the device capabilities (which in turn are described in the device toml file).
[sc-62011]
Benefits: Device authors gain control over the decomposition strategies
Possible Drawbacks:
Related GitHub Issues:
Requires #712