-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Fix decomposition tests #745
Conversation
709230f
to
8c5b54b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
==========================================
- Coverage 98.10% 98.08% -0.03%
==========================================
Files 69 69
Lines 9550 9550
Branches 746 746
==========================================
- Hits 9369 9367 -2
- Misses 147 148 +1
- Partials 34 35 +1 ☔ View full report in Codecov by Sentry. |
Hello. You may have forgotten to update the changelog!
|
We need #712 . I would suggest to merge it instead of this PR. #712 addresses exactly this issue, but in my opinion - in a more systematic way: it adds an option to modify capabilities directly so we no longer need to stick to a particular toml syntax in tests. The #718 fixes another toml leftover, it requires #712 as a prerequisite. |
Let's give those PRs the final push! @grwlf can you ensure relevant discussions are resolved with the reviewers and merged this week? |
@dime10 and @grwlf just commenting that this is probably no longer required, right? |
Probably not 👍 |
Context: Recent changes in the TOML files broke some tests.
Description of the Change: Fix those tests.
Benefits: Latest/latest/latest passes again (at least for lightning.qubit).
Comment:
The minimum version of pennylane-lightning required is 0.37.0-dev7 but those wheels failed to be uploaded. I have used 0.37.0-dev9. If the minimum version required is required for this PR, let me know and I will ask the team to push wheels for -dev7
[sc-63376]