On-Board check-catalyst workflow to use GitHub Large Runners #675
Conversation
rashidnhm
changed the title
|
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Thanks @rashidnhm, can we include the linux wheels in this?
rashidnhm
added
the
author:build-wheels
|
It would be nice to upgrade invoked actions across all our workflows (like what you did in |
It shouldn't be that much effort to upgrade I'll add it in within this pr |
There was a problem hiding this comment.
I think we need to revert the checkout action to version 3: actions/checkout#1487 actions/checkout#1474
|
I think that we can switch to checkout action v4 when we switch to another container. But manylinux_2014 is likely unsupported. See these screenshots and this link:
|
**Context:** A bug was introduced with #675 which caused Linux builds to be skipped. This PR fixes the issue. On the GitHub UI, it showed all checks as passing which caused the issue to slip by. When `fromJSON` attempts to parse a string that is invalid JSON, it returns an empty string. This caused the strategy matrix to fail. **Description of the Change:** Fixed formatting of format function feeding into fromJSON. **Benefits:** Linux jobs won't fail due to invalid workflow definition. **Possible Drawbacks:** None. **Related GitHub Issues:** None. [sc-61791](https://app.shortcut.com/xanaduai/story/61791/update-catalyst-ci-to-use-large-runners)
Context:
When high volume of jobs are being queued on CI. It is possible that it will take a while before a job is picked up. To get around this, we have provisioned an organization runner group of GitHub Large Runners. Since these are paid runners, we retain the ability to scale this up to a value suitable for us during periods of high usage.
Description of the Change:
A new label
urgenthas been introduced to this repo. Whenever a pull request has this label attached, all the jobs within check-catalyst.yml will swap over to use the new Large runner group described above.This PR also bumps the version of actions/checkout and actions/cache being used. This was done to deal with the deprecation of node16 within github actions.
Benefits:
Lowered queue times for urgent CI workloads to get picked up.
Possible Drawbacks:
We can still see jobs being queued for a while if enough PRs have the
urgentlabel at once. To get around this, only add it to PRs that are truly urgent. Also, we can increase the scaling factor of the group if needed.Related GitHub Issues:
None. sc-61791
[sc-61184]: fix for cache issues