Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax device-spec observables validation #629

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

sergei-mironov
Copy link
Contributor

@sergei-mironov sergei-mironov commented Mar 25, 2024

Context: Quantum device config now contains only native observables (it means, handled by C-API), while the device.observables may contain additional non-native observables supported by the device Python API.

Description of the Change: By this PR we relax the observables validation.

Benefits: Fix support toml schema 2 configs.

Possible Drawbacks:

Related GitHub Issues:

@sergei-mironov sergei-mironov marked this pull request as ready for review March 25, 2024 14:35
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@erick-xanadu erick-xanadu self-requested a review March 25, 2024 16:07
Copy link
Contributor

@erick-xanadu erick-xanadu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if this interferes with lightning latest changes? I am thinking specifically about the migration to the new device API.

@sergei-mironov
Copy link
Contributor Author

sergei-mironov commented Mar 25, 2024

Do you know if this interferes with lightning latest changes? I am thinking specifically about the migration to the new device API.

I don't know for sure, I think that it does not. It is only related to how we interpret the information contained in the toml files.

@erick-xanadu
Copy link
Contributor

I don't know for sure, I think that it does not. It is only related to how we interpret the information contained in the toml files.

Thanks Sergei! I ran the latest/latest action on this branch and it is no different than main/latest/latest. I agree that this might be independent of the new device API.

@sergei-mironov sergei-mironov enabled auto-merge (squash) April 3, 2024 08:52
@sergei-mironov sergei-mironov merged commit e681f9e into main Apr 5, 2024
35 checks passed
@sergei-mironov sergei-mironov deleted the toml-schema-2-relax-validatioin branch April 5, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants