-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax device-spec observables validation #629
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if this interferes with lightning latest changes? I am thinking specifically about the migration to the new device API.
I don't know for sure, I think that it does not. It is only related to how we interpret the information contained in the toml files. |
Thanks Sergei! I ran the latest/latest action on this branch and it is no different than main/latest/latest. I agree that this might be independent of the new device API. |
Co-authored-by: erick-xanadu <[email protected]>
Context: Quantum device config now contains only native observables (it means, handled by C-API), while the
device.observables
may contain additional non-native observables supported by the device Python API.Description of the Change: By this PR we relax the observables validation.
Benefits: Fix support toml schema 2 configs.
Possible Drawbacks:
Related GitHub Issues: