[WIP] Make a system for keeping docs and file names in sync #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
reviewed
Aug 23, 2024
|
Add paths to yaml files to docstrings of workflows |
|
It looks like the problem is that you're trying to resolve #78 here, but you need to modify |
|
Alright, this looks pretty good in the docs. I'm going to update it for the rest of the workflows too |
Remove unused `--longitudinal` argument.
) * ENH: use file lock to avoid concurrent edits to dataset_description.json BUG: docker tag in dataset_description was for fmriprep * ENH: Move lock outside the check for file existence Ensures only the first process writes the file * STYLE: fix style issues ENH: Add file lock for the bids ignore file * BUG: docker address is pennlinc not pennbbl
* Make all params lower-case. * Make models lower-case too. * Fix things up. * Fix underscores in entities. * fix * Revert some changes. * Update pyafq_recon_external_trk_outputs.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recon scalars are a special case in that they're shared across nodes and we have a good system for documenting them. But the other outputs from each node are currently just being sent to regular datasinks with the bids entities hard coded into the workflow code.
This PR sets up a new directory of yaml files for nonscalar outputs and their bids entities / metadata. Since BEP016 doesn't cover these, there will likely be significant changes in the file names, so having something flexible is going to be great.
Comments would be appreciated!