Skip to content

Replace --recon-input-pipeline with --input-type #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 20, 2024

Closes #46.

Changes proposed in this pull request

  • Rename the parameter --recon-input-pipeline to --input-type.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 33.57%. Comparing base (f356749) to head (36867a0).

Files Patch % Lines
qsirecon/workflows/base.py 0.00% 9 Missing ⚠️
qsirecon/workflows/recon/anatomical.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   33.57%   33.57%           
=======================================
  Files          56       56           
  Lines        6886     6886           
  Branches      894      894           
=======================================
  Hits         2312     2312           
  Misses       4477     4477           
  Partials       97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo requested a review from mattcieslak August 20, 2024 17:18
Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea, the recon_ part is unnecessary post The Great Split

@mattcieslak mattcieslak merged commit 0c9bdce into main Aug 22, 2024
18 checks passed
@tsalo tsalo deleted the input_type branch November 19, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename --recon-input-pipeline to --input-type?
3 participants