Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git re-direct, add build test #53

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Conversation

JanneKiiskila
Copy link
Contributor

@JanneKiiskila JanneKiiskila commented Oct 7, 2024

  • Improve / fix a few issues in the README.md.
  • Stop using the git config redirect, use directly the actions/checkout instead.
  • Add a build test for pep.

Ref: https://izumanetworks.atlassian.net/browse/IZUMABL-573

Update actions/checkout to v4

Use actions/checkout to get scdripts-internal, instead of direct
git clone with redirects.

Ref: https://izumanetworks.atlassian.net/browse/IZUMABL-573
You can view it via localhost.
We have one extra ] messing the formatting up.
The bare minimum to run the docker stuff.
@JanneKiiskila JanneKiiskila self-assigned this Oct 7, 2024
Copy link

@jenia81 jenia81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanneKiiskila JanneKiiskila merged commit 9a3d886 into master Oct 29, 2024
4 checks passed
@JanneKiiskila JanneKiiskila deleted the no-git-redirect branch October 29, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants