Support for Landscape native ILI9341 modules, and RGB (vs BGR) modules. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default (vs BGR). This change is backward compatible, defaults to existing behavior. Call setLandscape() and setRGB() before calling setRotation() to apply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I bought some cheap ILI9341 modules off eBay and they were landscape instead of portrait, and they RGB instead of BGR. This PR provide support for both these differences.
This PR is backwards compatible; with no changes to your user code, this module operates exactly as before.
But if you've got a landscape native module, call setLandscape() then setRotation() to apply the change.
Similarly, if you've got an RGB native module, call setRGB() then setRotation() to apply the change. (It's coincidence that both these changes are set at the same time by setRotation().)