Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fzf_configure_bindings] update help message #267

Merged
merged 9 commits into from
Oct 13, 2022
Merged

[fzf_configure_bindings] update help message #267

merged 9 commits into from
Oct 13, 2022

Conversation

PatrickF1
Copy link
Owner

@PatrickF1 PatrickF1 commented Oct 13, 2022

Received helpful feedback on fzf_configure_bindings being confusing on https://www.reddit.com/r/fishshell/comments/y1hovw/request_for_feedback_on_fzffish_quick_survey/.

@PatrickF1 PatrickF1 changed the title Rewrite fzf_configure_bindings help message Update fzf_configure_bindings help message Oct 13, 2022
@PatrickF1 PatrickF1 changed the title Update fzf_configure_bindings help message [fzf_configure_bindings] update help message Oct 13, 2022
Install the default bindings but override git log's binding to Ctrl+G
\$ fzf_configure_bindings --git_log=\cg
Install the default bindings but leave search history unbound
\$ fzf_configure_bindings --history
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One notable change is I think --feature= is a better convention than --feature to disable a feature, so I removed this example and updated the usage to reflect that.

@PatrickF1 PatrickF1 merged commit 242843e into main Oct 13, 2022
@PatrickF1 PatrickF1 deleted the help branch October 13, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant