Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix elusive calculations from gems #944

Merged

Conversation

kkevinchou
Copy link

Addresses issue #564

The bug also applies for Nightblade support. I also went ahead and updated the tooltip which appears to be the pre-nerf tool-tip https://pathofexile.gamepedia.com/Elusive

Copy link
Member

@ppoelzl ppoelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split this into two separate PRs?

@kkevinchou
Copy link
Author

you got it chief - could you clarify how you wanted this split? by gem? or the tooltip update?

@ppoelzl
Copy link
Member

ppoelzl commented Jun 1, 2020

By tooltip update. The changes to the tooltip and the skill gems are unrelated, they just happen to both have something to do with Elusive.
Pro tip: If you have to type "and", "also", "additionally" and the likes in your PR, you most likely want to split these items into multiple commits or even PRs.

Copy link
Member

@ppoelzl ppoelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you need to edit the export files, not the data files. For example: edit ./Export/Skills/act_dex.txt, not ./Data/3_0/Skills/act_dex.lua and run the exporter to generate the changes to the data file, then include both in your PR.

@kkevinchou kkevinchou force-pushed the elusive_from_gem_fix branch from 4b9b197 to f399b99 Compare June 2, 2020 01:35
@ppoelzl ppoelzl added the enhancement New feature, calculation, or mod label Jun 4, 2020
@LocalIdentity LocalIdentity merged commit 885f647 into PathOfBuildingCommunity:dev Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants