Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial OAuth implementation #8525

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Feb 26, 2025

This is a very early implementation of PoB interacting with PoE's OAuth API. I wanted to get this out there in draft for early reviews and to organize my thoughts while I check things off the list:

Required for MVP:

  • TODO statements
  • Hardening/Logging
  • Investigate if SO_EXCLUSIVEADDRUSE is set in luasocket (part of hardening)
    -- Pretty sure this only applies to pre-Windows 2003 installs and people running PoB in compatibility mode for that. I did submit a PR to luasocket before realizing that, but I may not need to bake it into PoB's implementation
  • Automatic token acquisition on 401 error
  • Add luasocket license
  • Open SimpleGraphic PR for luasocket artifacts
  • Server start and timeout messaging/UX

Future goals:

  • Secure token storage
  • Refresh token usage and storage
  • Investigate behavior and QoL with multiple PoB instances open (Access token currently stored in memory, focus PoB window when redirect is made, etc)

@Paliak Paliak added enhancement New feature, calculation, or mod long term Large or strategic commitments labels Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod long term Large or strategic commitments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants