Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Firestorm of Pelting skill effect duration #8493

Merged

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Feb 18, 2025

Fixes #8492

Description of the problem being solved:

Firestorm of Pelting doesn't have the duration tag so it doesn't calculate the skill effect duration. Firestorm of Meteors has the tag when it doesn't need it, so it's probably just a mistake when we were adding the transfigured gems.

Link to a build that showcases this PR:

eNrdPWlz28ixn5e_AsWqvErKlIT70JOSoijJkle0uKTkI19UQ2BIYgUCNABKprf831_3DE6aIHh5s3mbik3O9N09PT0Xffavr1NPeKFh5Ab-eVM6FpsC9e3Acf3xefPx4frIbP7rn42zHokn96OLuethzz8bv5yxz4JHX6h33rQALSbhmMYfUlLKE7TNiB9PaOB3ye9B-DZwzpvvA582hSHxHTdOv9keiaL3ZErPmx_d2J40BRLZ1Hc6eXsCOCEhsWMa3iHb9jwOuoEDvSPiRdA9Ja4_COxnGr8Ng_kM1GkKLy595UC33d59_6Egk-sXZQKdfjnreWRBw0FMYiGCP86bbTANGdMbNwZSxJsDHU239GNdknRJk5sna9Eu5mEUX5IpfMzQJUmxlGNZVmRFVKvwBzNKnQxFOZZMPfvPqELqhfRqNKJ27L7QTujGnQnx7QJj9bgSdQfw7tyL3Znn0jBHObYqLXLzIwNRrAJ-CGLiXfYGOawpaWA0UVZUQ6o2G8cLcl9Vcrgd-25MiyxU0zg2NUtTRVlTTLMGccmnliYdq4oJMSFKmlYn3g5sO3PPg4FXxKzUrU8jGr6QGIbhRvCdYDp0feq0X8YZsKGr5rGoWoahy2s0aoeU3I941PWJ486jLo1DGhVCojKIusQnnSDKnaVUBwTC9mgISSEuodQhDKgdQB4poqiGuQGX1biV7O7cEd0ccitNEoRtpdlNj6vBpnBbE95NoD4Ms80gB8Hc2xAyLqQsXa0eRl9KkJJUBXlJv-ZBXEnv1s9lk3V5DdsSpKVUs30JcJDXa8wSz9VNr5B7ZU2DSUgyVUsRq2eUySJybeJ1yVd3Op9CDn8gz9Qv2MRSpOooHE9iH5JWFTZk8korXLsh3QWvE3jOTngTEkSViKpmrBtrGaBuWuaaKd0-Rehb394kqBD00Q9ZLi_UAutYIEofBhcWH0OPboyTs0kG6SZzNGc2pn7CcZGzk4_XanVHqT15C7UacCsWVmuTeT4gNEtca2OELtpYltdOQStsDFWGtBnKsr0s8VgxoQgQ8c91JFZbDgflWrStTXfl03C8GExc6jnbQafCdchsg5SKhi9iFx1g6ZvxW2WRjUTd2iofSehsNvdsK9ULiYoZWa6xGAcvRWvl_NGlHqWA4dClQlqsXhAEv-NywNsOrR1Og3m4odM58GYapNMJr5771Jnbm81f2bLmwoPl3ZIe1WM1QwNJPW8VbmVabMcxsZ8vA2e8sdkYk60wyvIN5rMZ5BUMiE0J4CwJ1b5bqHqOdK0e-h6ieaNxjdPp5gxy6I0ZZEXC5lyWUDbXBaf4H9hsAr4xi8yhXcgXU5gY2Dq-GziF9ZBUOTyuYY230YKNAZaXkdU5IHgF4Se4NxNtBw3VUF7VVooSUv_bYmP6JfCNGFz5zjzE0bAxj2WMVWwe3Clk0yi6JDERnKSO_kBCl_ixzPaNIkpCe3IH3r8mnjeEZHDeLLayb2yv6dr1YhpeQhsyRcGWKUpIERmfnbBdM_x0O50FYSzQr_hXj4TxIt3GYoCsBehEseuzlTykJM9rCoNJ8Np2XpDTQxB4Ubb3RWYz6jslGg8hpQJJE4yNQjDl8YswJRFIveARC2T-MA1FbsGq39C-t_7QFMk0W5pmmjp8k03dFFuaaIn4TZU0WW5JhqnJ2KdJpt6CmkxXv5f27W4dZgo_ACWghFaAniTLmthSTEOUWpqqqkZL0XVFbUmiJGnw2WippmyZLdmQRaWlqiCQpBiS2pIBFoTTJACRDV2zWpoCC5eWbCqK2FJlw9JakiYaCghp6nJLlizNbKm6JYkt01KBs6TKAGiAtC1DB4qKohoW4Kii1lIlWVdQIRk6FQvwFFVsGRrIIGmGJAF7WQMdNdUENmASrcUtIlm6AnKDQYyWLinIAZYYOgit6i1FM0QdZdOhWRFFkaFCuyqCipIpGSqQlMEIFiqqyyKwB_MbZguMbyAnA9TVQQwAlE0LDGchFZUDKqinYckW_Cmh_GAQHURl7RKgtbhrdMWwwF6GrKtoHRBPUXQFHADiAR3FQh5obxYA3PGSCACSjubWRBFYSLIlAQtLUtWWYSkIAcrJsgWCi8y1ugEiK4psAX0LwghkQN_IIDggKoAK6GgnYAhm0TXQU1NEVW7xeJIlkREwwPSSqFoiftY0JAyfNUQA00GYARkLnARswYwKmIgNVtxRIOGiXY4_34UhE8MwKOxKy1qy4YwAChsRv5w99u_Yh18mcTyLTk9OXl9fj2ckngQj-hXqp2M7mJ7MAAnG0lH07HreEZI9acN_F-Nu-99fv9l31pdPd59N8k7tXgyNxRfy3O0_Xn4cfNJ-P_pdfr0Tex_mX77Y4f385m3ofXobf1Ndq7Ow5--6zktwd9PryJM78aPTnt9LFxdSr_fBoq_vXWswvH7tXC2-TT4qL-6vF52Lx1_v6Bf7dvY0eRcFj4v-i_Hp2-Lhs_n88cj1F5eDx6ejzmQw855-k78Ov30Z9r0vb7_NPn9azB6fp-_co4fRCJLir2PpiWr9q_gp7Lo33aeri7b99M58H3f9618XF2anfaTeWvcvz799pp2rd-H4UXr37-HD_c2F_knT7z4tvn371e167x7G5mtwFPSGv_17-GH8eUIeaC80Zl2_3f70Vvbbt1o4cT-_SOHt5Bt5iJ6u-sOF2x2fnzPDn6SWP-Mb9xF3Q_KNZQ_mJ8wTTcGN6RS_JhUfoBexznCeDl3INzzJn2CiY1kXMyF-eB_ElMFiY_rlbID-jCCbh_FbOo0uFjCxXuO6It8aZVNtkkoRekBjPksUcc6bcTinmP1HZO5h-29z4rmY2cVi6x0_M_GDcJptrQApyOxYAnKKD4sZps339_1u-453tr04oYcc00zPM3oik-A6aZZPGtmZSDsXvEM8O2Kiu77tzcG6flJ2ZDOJR4YoHp4D4S6Ck6q1RClj9MsZyJMAv_WCIfHkFCU5HYJVkDDmnuvSmDgw6Z7cgiujE9TkhJGDT1ifRjFYBadrNnEiRtYK-n8GSyDwivYvBVMnnxHqklu9WZJPSuVb0tAO5j73q0-myZyZsRGCkdCjHszH4yT69lc8c3cbqor0RCHTPOnO-zLdf-j5Wdov8e66PsuifeJG1Bk8Qw0VBz4C0fDwRrkhvmNDmcJXb0Gyt7tsnls_pn7kjhY_2qfQ9bMMlLM4uPoDYofuyLVXBkWhc1nrQtfP0jpncXCt2bEien2l1hgJV_YkWKF13vXTtEYWAuNRqzYTD4v4POEeNBmuSoRlzTMJGPOfkhIP5v2NJ4BPFRPApz9pAgDpaRBGefmBwvyXTreQtolPO15Ankv2LrVn1i61_sTpBpgInMuBg2vgjl3vfsR2OMq5pdSR55VS80_LKciFlRaMz8HT6a1vh5TAZH05D0m62bqcVrtBSPP-5cxa7v1ZhkAuQsbmZxRYEFmDeVhZY-XdK8qsvPMnhz7n8v8hvcAiPATjlKydtWUmzlp-ll1TBj-YNPkIqya2ROSLQPzIjMogbv3ZPGa0zptTN7KfhvPRCC-TgQJxyG7IXV1fX3Uebj9cJRuLRRSm5JM_nw4xg_C_s7Xr2YCyww8hmg8j_vG8-cGlr0yQSzCs60WokueRWUSznT22xEsk9wBvDTUGdeNmF9BW08oBqildfaUhLnw-khAKP1opV9ZfIxRniGdquBFbRQ0vclUT4ic0HagU-ySupMEv0lVTwZtslepg5xrc2-mMeJWck94aS8S4zodAxWoa97DXuxx3BTjUGrvYNmRRe7HG38nxUjWNC49dP1xNgHdWI_cCN8KZYjV20rvGquyCXaVVeW81-iW1SaXuvLMaOTtIDnx2jryaSga1htL7wGdBDoOm7Xp4FFTp2SuPZiDVBO9jWGMnu_VVlLqQo1KQtQMndIfzuHoYFyDW2IpdfKmwEPZVo_L7HBU6YN-aTFS6z1Bh0CJMNSl-CaAyka1D5ceClfZLDhnXuCA5Ya8wP-9dY4T0lkGF_kn3mkHC8m_7JXAdftBcMVyWwNYljMB-3p8MOz3fn8zycfr-FK89Ej1X-jvprUZ_jF0saFZQ4YXLRkRwUO1HAcfWfhQeoM6M5yHdmUB_uRLJcfvra5Ds_Hclctq7LnMkx8I7U-CH1zujJyvJHbFZ_odqmIIGayeADGbN-Ijnfr6i24sUE2t1Ism124oWnwpXaro1RT7Ak8uc63IAB6khBHP5zZpqcTNK2RWRG0q8eNILAm8_gj9cWt2HGN50m8-I76Tk7lfV6LkfNrReEEdAk919uMQLdfva0KfTxQpC1XKdnaSrOnYrAtdZyV2OQRzi6vhbEEw_4-OAY0uXNRPf5miywduT8zotOaOD-vvSBS-GLPpSrgj46bx5ZEnHiqnqimVJhm7xS0xnbHmcnB_i5-z4sJrePKL8nvxHSmaBzzAKJ35IJV1ZM9GSz20PvhrN5CCw0KqcN63id1jVq3zF32cL5FOhf3V322mwB1inwkUwFgYTsKLf6IVuNIVcYQvv6Cv1GneUjOf0VLijY1hmsL2rSQgrGNJIrrucCh-oH0yFS1giP9Mwb77G_fNr6uctVxSWi8LA9VD3vLkfxDH1hU4QFho_AJQAqyrgxTJXlHe9xythQy8InLztISCO0AOb5009CEI6de28ZUD88dz1Kd9-a_AlNXWEDEBr3JBIAHvlTeifHLLUZSxDCw-vwRoM3q3-iAUGpWvxOIDV6NMvc9ygFtidB4F5rwFG8lwbUtWpIDb-SHx-Kn0_Ojoqu0aAliLAG0kU_4av7MAbQhwIQzQMrteoUwLT_oa9hG1Isewj8JIX8SLhdYKeWoX4OZgLNvH9IC6SThAw-1OB4P9jwaOwsBe0BCYSIAMsgnlOS2bKpAFV1kP-_h6G9nAhYJ5wafQ_MICi_xXYhb6CoIIbFc0jf68BUBjLUsSW-Srf30KBEUcCSxiCLGL4uaOFwNbuRbhEMN7vggVAWFBPiCFhCQq4wE23bQWeyXJklUlRGCBlGVS0cSgkVxocmGMYYeZXPL-AClCA8hhCCCz6OBuFAXzke4usD1_QQKYC0ZK7uisESIiPYQUstB0HhOSW45ACxe07jA-1wBPptgS38A2ti4EwgbELkRhD0GEIZBGFYsNk5DlChDfbcgE0HsfL2aBsB20pBoQJeaHA3KOOy2aRImjZ4oXncwLM1jCQwNUsz3XmYUSFNlROiYFzIjoTKs9DZWn0ks2IcAGMBKznuSUyi8kasxjrzgxVIoMrm4jbBgcIfACRvFHRGUuey6mb3B8ZX-aPXIpd_WEw1bN0W9YcOmUxyxZXHrsVC-IU8kURWCt5Ir-_LrB9vGpIfIeIuvHqqhqORzqHyk4bcnCTqZJOE2VNzO93AbhFy204AzPxORoNifZhQTakMDKhfgId8W2ItyjSwDExZUcd3Dm4BypggZUDWUyI8sxUFsX63qdTwIy4Udl2h8D3O4pAuEUlJOUhl9j1o5iCn9io5O0lbAHyATTBlDKbMaviRoTAqpeSfEqZLBqC5Ty2xd4NnD4IT4UQ_zxviscar0fkdBO-EkKphdBqIfRaCKMWwqqFkMR6kHptpHp1pHp9JLMepF4jWaoHqfegXK90-j5kHUi90nK9F-V6pZV6N2YPHNkhV15884guV9Dt_lWjPKAuAlj7NC4h_Uy_zClk2YGHYyuMynCngiRZjeLGJc4ByesyyH_Q3-iEZAR1YFIW9kI6cr-eCn8weU9BXMhPkPWzA98isYSQtgorQ8ChrK-CSB8zfKBeAFXlQmsM5iMGhD-csOZLcl3xFEqhRnJRE1YWR-x_DZYwoHw9hXmpWLHKjT9iMo5OI8z43yXIlyE-FIJ0lMqRTgYFsIK0f1e1I038RzHrd2CR7QSvvpA-5BLwyIhlwYwkn88NtYhXzqxvLBnnsWkh8zXKlcOSgOtHZH34HiBdqpsm1FXRrdRG91sPZ6HGtQs0Q3xPgYXxc9q8HOGmvG-E18fqbmOgGks_cKwbpViXkiC22WOMJ4fVBK3kL95YCm1JPpL0UmjzO2lJjf5G0YoRWg7fbUP7rxO9q2JTrY3NzgTSbePh1fWwKIehPwYHkeWgNEX9oEFp_RlBKYmHiMrlLKyW9w3emOqOwSQpxn8smlbFilYbKzfUm9K4cefaE75ZEAkdN7Q9aFuKF8U4bBIz_ox4MQ49YS-HirpzqIh_rVDRa0MlkfzBhcWrCyIPZi7Aps3L0SJqhy3q2DlrQgEyvvZnRI-1f_QUYkc3y7GjG6VKLdt6ZJo23ujWbpH1nwwiY0UQ8Xn6I_EdMH4wm1B7wb_VBgB_Vs4m-HufHwZoNXBt38HdoxRczcBLPlvGxdtOuG80iEP3OXnDrqyCZqGSQuc_A6buHQ3blkOKfqSK1eWQqVZ2Le0Ksa5UI4EbIInFxhvZYPtX_OrhD1C5_lB-ScVgRRf8168BzBWxfEG9uHFDyctCYB93nfFYmNSGZhxSfxxP1s1heTxp8qp4Iul9pmL0vPm7rB0p2j_QZSkTmMnE8ve_0ASF7_uqTwXLT_-8IGaPJXvDx_4dnm_yG6l8YZa_o8yCpwqBsxGkHMWoQ2E7HkJ7uIgiHCX8HaeWExBrCUBMLePLW-CzOyiCsgVGqqUweCWzZdbqLoT2UD-hIR-AxmqF9AMopB9AoZ1orFJI2ia4VkWncgCLyIfSZpt44-uWveyxYrDpe0sgb00hR9B2Y6kcyv7aAYJBOsDwkA4gh7plJOTg5l4pRt53RKoHMOD2c8ZK1zNitw6AZ79GwH4wJEVll2KEpKlIeh8DKvsaUN4zB2wngLNIzwr3CGJenOxDYXVm0PamoG8YF-yHVcpxkTQdKi6kQ2W57QfH_o5Q9w4G7TBRuY3y7encK05PO-di5QApTdk0EPnPpZQCMf8FlQ0DcVVaUPdMK9JhHLjzZL911KtbY-xSCOYo-i5W1fadLQ7kFvVQ2elgS4OdV4Fb4PVdf7yV11fnNvkwPtAPtUw8xJpV3U2nHEvdyPj7VxkHKne0vQXZf47Ut00GOby8U_L4kSHfuOIvq_HCPXHogF22_0jxLDbiN_LZtTL24DrwR-44uR7PvyQX5Bl-1iLEbuzRwpvw4pZX8eE1PtMuPdofBoFHiZ_crT_5EQO31Fy8C8ieFvBHpk4FXs8jNp0EnkPDBJsiUvJPdqTPvA1RrEEo_R5piqbUYWW_fpq-6k4xZVmV6jgW_pWPFE2rwSn-xGyGU6satOwgH_LaAY1t_-YYploNP8126z-67L65M2CvyPGHAwbUGxWe6Wsb6Li1YTLv9fClTub0TbG2dwTG2LJJTUuvQcsemGbWECVV2SC6llkpm0TKprYY2AF7sAMOi374PYVKDsmPTQeexzbbiyO0BjOdjFIEXbJMqxonKvxgzABPZ7cQsvzL2FsPmo0tOIGUXWHAs5Ms0fIHU-zbPxtnJ8v_9tP_AUyI1tY=

Before screenshot:

Pelting not having duration
image

Meteors showing duration mod when it has no skill effect duration
image

After screenshot:

Pelting with duration
image

Meteors duration gone
image

@Peechey Peechey added the bug: behaviour Behavioral differences label Feb 18, 2025
@Wires77 Wires77 merged commit 5ed03e5 into PathOfBuildingCommunity:dev Feb 20, 2025
2 checks passed
@Peechey Peechey deleted the fix/firestorm-pelting-duration branch February 20, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculation Tab Does Not Show Skill Duration For "Firestorm of Pelting"
2 participants