Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black background to detail text in character dropdown #8487

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Feb 16, 2025

Closes #8486

Description of the problem being solved:

Character names are currently drawn over the top of the details on the right of the dropdown. If a name happens to be very long (often happens when using tofu for utf-8) the details stop being legible. This adds a black background behind the detail text to make it more readable.

Steps taken to verify a working solution:

  • Tested by importing pjsdevil#2432 account and previewing characters from Necro Settlers league
  • Make sure the mouse over hlighlight works correctly

Before screenshot:

obraz
obraz

After screenshot:

obraz
obraz

Character names are currently drawn over the top of the details on the
right of the dropdown. If a name happens to be very long (often happens
when using tofu for utf-8) the details stop being legible. This adds a
black background behind the detail text to make it more readable.
@Paliak Paliak added enhancement New feature, calculation, or mod user-interface Changes that only affect the UI pob2 Label for features that should be ported over to PoB-PoE2 labels Feb 16, 2025
@Wires77 Wires77 merged commit b26c2ac into PathOfBuildingCommunity:dev Feb 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod pob2 Label for features that should be ported over to PoB-PoE2 user-interface Changes that only affect the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encoding issue (sort of)
2 participants