Add Molten Strike (+Zenith) ball average overlap calculations #8427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l as a total weighted average of normal balls and 5th attack balls
Wires77
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
This looks great, thanks for the PR! You're right in that there isn't a way to use the DPS values in the preDamageFunc, so I think the way you did it is fine. You could add some tests, but I'm not going to let that hold up merging this since it's been sitting for a bit already and it's limited in scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8426
Description of the problem being solved:
Molten Strike and it's transfigured version now have calculations for average ball overlap on single targets.
Zenith also has a weighted average of its normal and 5th attack balls to estimate overall ball dps.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://poe.ninja/builds/settlers/character/turdtwisterx%234882/NeedForSteveUnderground
Before screenshot:
After screenshot:
overlap chance calcs
zenith weighted average for overall ball dps
I had do a bit of a workaround in making an effective multiplier instead of actually averaging the two final dps values for normal and 5th attack balls because afaik there's no way to know those values in the preDamageFunc. The math is right though.
This is a little big for my first PR, so if there's anything I'm missing please do let me know. Feedback is welcome and appreciated, especially for the zenith weighted average if there's any better way to do that.