Fix full dps visual bug on gem dropdown #8087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
When hovering over a gem in the gem selection dropdown while having anything other than full dps selected in the sort gems by dropdown the tooltip would show that the player loses all full dps (see screen shots). This was caused by a funky lua behaviour here:
PathOfBuilding/src/Modules/Build.lua
Lines 1864 to 1866 in c76a5fe
The above condition would return false even though self.viewMode was not
"TREE"
see below minimal repro:Before screenshot:
After screenshot: