Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sorting unique item list when added item isn't equipped #7418

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Mar 24, 2024

Description of the problem being solved:

Before, when you'd drag an item from the unique list to "All items", it would trigger a rebuild and thus a re-sort of the unique items. If this sort takes a long time but you're adding several items at once it can get quite frustrating. The rebuild isn't actually necessary so I removed it.

Steps taken to verify a working solution:

  • Drag item to both items lists, no re-sort happens
  • Drag item to item slot, re-sort happens
  • Double click item and add to build that way, re-sort happens

Before screenshot:

image

After screenshot:

image

@Wires77 Wires77 added the bug Something isn't working label Mar 24, 2024
@Wires77 Wires77 marked this pull request as ready for review March 24, 2024 02:25
@LocalIdentity LocalIdentity merged commit eb27e9f into PathOfBuildingCommunity:dev Mar 24, 2024
2 checks passed
@Wires77 Wires77 deleted the unique_list_sort branch July 29, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants