Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to DPS display for mirages #7375

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Mar 4, 2024

Fixes #7372

Description of the problem being solved:

  • Adds a display for mirage ground effect DPS in the sidebar.
  • Uses max(mirage caustic\burning ground, player caustic\burning ground) for combined DPS calcs.
  • Adds (Mirage) suffix to mirage fulldps displays.
  • Updates "Total DoT DPS display condFund to also check mirage on ground effects.

Link to a build that showcases this PR:

https://pobb.in/jXQRO8W5KGuL

Before screenshot:

obraz
obraz

After screenshot:

obraz
obraz

@Paliak Paliak added user-interface Changes that only affect the UI bug: calculation Numerical differences labels Mar 4, 2024
@LocalIdentity LocalIdentity merged commit 5b13ec6 into PathOfBuildingCommunity:dev Mar 9, 2024
2 checks passed
@Paliak Paliak deleted the issue-7372 branch March 10, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences user-interface Changes that only affect the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caustic ground from Mirage Archer - Caustic Arrow deals no DoT with Ancestral Bond (wrong damage source logic)
2 participants