Fix formless inferno not increasing minion life #7370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6149
Description of the problem being solved:
Increased life modifier per over-cap fire res from The Formless Inferno did not apply as minion life was calculated before resistances. This pr moves the calculation of minion life into
calcs.defenceright under the resistance calculations. The values calculated bydoActorLifeManadoActorLifeManaReservationare not used by code above where the calls were moved so this should not affect any other interactions. I understand this is not great code quality wise but i can't think of any other way of fixing this without moving either the functions calls (this pr) or resistance calculations (#6663) and out of the two i think this is a better solution.My tests tooling (#7162) confirms no changes to output values (Note lack of Output diff sections. Bunch of noise due to the build xml compare. Still haven't really figured out a good solution for that.)
artefact.md
Link to a build that showcases this PR:
Before screenshot:
After screenshot: