Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dancing Dervish stats (Life, Damage and Damage reduction) #7353

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

LocalIdentity
Copy link
Contributor

We previously were using the wrong minion level for Dancing Dervish as the skill itself had a level requirement of 1 so we assumed it would use the level requirement of the weapon but this was incorrect

Since the minion is Unique it is meant to have the Unique monster mods applied to it

The damage taken stat comes from the UniqueAnimatedWeapon.ot file which we previously had never used

Fixes #7294

We previously were using the wrong minion level for Dancing Dervish as the skill itself had a level requirement of 1 so we assumed it would use the level requirement of the weapon but this was incorrect

Since the minion is Unique it is meant to have the Unique monster mods applied to it

The damage taken stat comes from the UniqueAnimatedWeapon.ot file which we previously had never used
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Feb 17, 2024
@LocalIdentity LocalIdentity merged commit ee608b9 into dev Mar 9, 2024
2 checks passed
@LocalIdentity LocalIdentity deleted the fix_dancing-dervish branch March 9, 2024 04:16
@Bellabong
Copy link

This also fixes #4283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minion life for Manifest Dancing Dervish is incorrect
2 participants