Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix summon skeletons duration #7352

Conversation

mart-mihkel
Copy link
Contributor

Rename the skill name of mod tags in ModParser.lua to match the name specified in autogenerated files.
This enables calcLib.getGameIdFromGemName to return it's intended value when called on line 681 of ModStore.lua.

Fixes #7337

Description of the problem being solved:

Reduced skeleton duration modifier doesn't apply.

Steps taken to verify a working solution:

  • Create build with Summon Skeletons
  • Socket To Dust
  • Calc tab shows reduced duration

Link to a build that showcases this PR:

eNrlHGtv4zju8_RXGAEO2AWmedh5tUh3kSZ9HdqZbNLO7NyXhWIribaynbXldrKL-e9HSXbiPOTIteduDzdAp45FUiRFUiSltPfzV5caLzgIie9dVBrVesXAnu07xJtfVJ4er0-7lZ9_OumNEFt8nF1GhPKRn07e9cSzQfELpheVVsVgKJhj9imhZP0GlJbIYwvsew_odz-48Z2LygffwxVjijyHsOSTTVEYfkAuvqhMbECuGCi0secMNu9jwAUKkM1wcM9n7UfMf_AdGGVBBKMuIt7Et58xuwn8aAnCVIwXgl8lzN3D6OP4McUS8dIsgUTveiOKVjiYMMSMEP67qPRtRl4wgAJX98QlDCgiGgG5TqWmQAFdojm-TcHWj8BeRkHIhsiFx-M4kyXGzhrMVIGNAnw1m2HB_yAgbLBAnq1BPi_sQ0QZWVKCgzV8o9pSYdzuEW_UleQffYbocDQ5zoiE9DU0_pmwxSUFDWrR5dB3c48wrA0-8knoe7m41gIeRJSC42nBjnGIgxfEiCYjA9-dEk9TJw_IQwM_3Oi60c4CHeEAXJltYdSPIEyw7YP3p1EsU2OSw6jK2e7JDOtD5hIkRsjLzdvkuJrowuUm_DaGxhDI9CAnfkQ1IdkmwJjK-DLEXzdQSlp3HtOAGuM_0oCNVsasLz4T-5aWy1_djjZUzXq1cdapN5uW1TzrKqP5YhUSG9EH9JW4kQth9BE9Yy9FxlTb1XzBPAgdKtyO0n-vSYDzYw186rwBa4H8MD8a9xodLcCuaZ9z4DvP1vPFJy8QYTS12WZqeYbH4CJ8Q59SrIuymST2NJ19Uc41x1484WojUPUsC-keY3txA1nSGDGsF403S9DMVC2H1VItBzygWjX5bYQcauKIh9XUqFpZSDnVdOXhYL6aLAimTj7ohLEBWmrlffZ5GltL3dvTHbQZHdScKvmMAkdvm8jL0wsK04FWnXtIdUlwPcPEkBYCgoN1099R4P_OE2yaD60fuH4UaC64BNYSINkjZCExxk5k621KlxSKJl3ugStKc2H0GUP289B35jjXJLkw1rWOQJ1EyyVEDL72ugT4Xgd5M0nlIqdtDeiPYLha_su3Rf0JNtDaE6w3ev1ZdlD0ZeGbdQ5hNuDaU6wX9AFCgwshX9S9UMpvfF-5OFAqaZUyAlCz_hr5r8D5gvc4wnzQkNRsyhglKwH2_lxp098C15rgynOigLuC9hy7GFrTHG-YyLH9JshO_6MDiXG3Yza7rWa9022pkLe7IbCxt81SYPd6D2dds9rodjvthtXumtloBxoRe5AHGxF6kxzuSujj7rco8gl3yF_2gDP6FXuwR_oV-7QP9Cv0RNguF1qtRhZgdm5yECU7T9pDyUwdM6Fz8qafyz0SFxKhMBwihgwnLmw_oYAgj5mipRpiFNiLewjm14jSKeztF5X0W_FJtGGvCWU4GMI7Hkb4HLsUG0kY79VEO5k_3blLP2AG_sp_jVDAVheVGaIhloDiDdAJGfGEyUAEobRiTBb-a9954TM9-j4NEyQDLZfYc7ZoPAYYGyjJF2zOhBCefzBcFALXK7kBhVyaVDf6zhFieD4wcFFptc7q7fdt06q_b7WsjvW-1e1a1nurW292uUp4ywQFq_42vkeAXQYspHrlphW3weUEnJt3vafxvXh4t2BsGZ7Xaq-vr9UlYgt_hr9C2lm1fbe2BCSQ4zR8JpSecrK1Pvy7nMPPhyW5uZ5-efzXBD71LwTRWkK1J3vloZwi_iQk4zxY7bbVrBgQZFz-MXaUfTgu_D5Yr5Ym3uO7fkBAZdLGalzPYtH5QvCHDz7DApa_TD70JlykEIwpYDfYDS9X4PDX3IR3QkC8khx6gpk00jROckDg4BmKKH__S4Qo4YZVT7-9l2cZnh-461YLkALD4gmlpPi4WvKV79_fy5E-ZTExPl1iZdKaYoYM4iQWFr8URxX9DdcDRO1Q8E08m0agWS9OYtZWTNGU88YPZ3iDwUkfeqQorSd61wN-YuAb6k8RNRMUYSlxiNiePTUSvxwjEmJn8gwxgfFaIj7uMUFvc7nkD5ghB4JF7Q5sIKxxLdQEWXiaRK7LJ5HYIucQbs_x9sbE5OqRFMOC1z9SSxg_c-ShXM3KluiNRPQd5dl-5El78ZAbhwI5u3F4-j2FrM2dw_wfrvAnhGjWKh8cX6-0evQ_tdqcAyPXkg_E9lDKwouNQHvZOfT3W_hYrO_n4BAov6idPDX633J0w58ZD0iURn_H5f8f93pY4F___p7PbaAPeaxIqjOsQMLsW0H8CJu-SG9kAsMfhdoFxJ23jJjg46LCEwg5QcWYQtKKkZfOU3eAObHfvMidcj-VvzddkDSkS0L7t2k0m_GbDyAHC8Rljqvr66vB492nqxhlgkWD0AijaSgfQSsEvwquh7D8hIZcd5SiZYjXGbRIZ2IxKeBlUBNQt2R9t-EwrQ2AmtLVVxxAwj__DFVGQLCSr_X4EabkhLx64gWPihqv5NWEZGOTBwRZSSk0JboOair8EoVSHD6YgQulEqLKmePRI5pgPKEFjyAzYvOKMXvJeforoTL0YttRgOxVxnrHXVk1DdEaURGQg2pk2eBQYcejGVoVvRWlVuWoGn2IbaSUXQ6qkdfFue-JG0SHqayhMih98D1h5OA0fUJ5B1W5slcUr0HUBD8yCHlxVayi9ACRJwHJdJyATCOmduMURIauRDNHoSE-pkaVR5sKGfhYRiTa6tkoFJqGUZOSx2TKQJaFKrvpSv3FvfmMJYgPoRTql6MZSkjO4RTyx8MZTiLib__FJ448n1G4yw5YVsDw7efiZMShU3Eyu6dQxSleUxQ-K9c7HlWjPzHCM6cDVGSGpEWEO1UxCty3ilEY7yYSG9xxdgqxPvg4iJyMZjl-fB7yZgry1ObN6OJQ6c3YInxD1oxBgsz4vYbJMG8WeUNQBsswbU1Sgq3DcWAjXS5acic7KGluitI_48tIWS4sQY4Qgq34NiPZ06O0Phi9xYjywxyfFiO4d-mqkJw-C5HnDPnxREFB-elGtARiCWcfj2XrO2R7taTqEg1_XtrExxQTFvCS-0_fd79A0dutnnXPzJZ11rEsqyPfx73gbtz_hZR3SEDzgbCYxJI44K8XlVOz26yedTpWp9Wqm6Y8HO2JujnuTfPnpDUdhVhepvyM0RIqXf461TXmoEktzQ9a093jMbxmq3Pj6cPdL09XJ4--MYxCdjLgtS8z_olfMT2JT1bOjVGADatar9Z3X5lb7wZRAEKxE1nMYcdYj1gnUEFQYoPJnhv1k78g-M3xeb3a-vZDo35q1n_8hxHwWyaAk9TFRhIV0tCywg0NBwzW-KF72jABk3h2gBEsoSGX7eSvWObzxjczPbwmLcstQ9RTG2jzvfUtzVnntFH_8bvg80LPCLOxrdPWYeTkFsPu9Na3gR8E0RIUL1oJULGPOTlDEOU3-lqJBcTNBiWEeRTCOgrRPArROgqRXMkSjaO1SfNzELXlbx-RUJ-JE6XR9Gl8zx1VtjUkltHYHDfVE2ZUKJcY_KI_XYUhb_bIkyszB34y5S6NVn4aphYNMXTnAIGdEzZJS7i4sTlzS6bSFWPyipa7fLRL0Ee7BH3koXHpwz6zS8DKQeAWQ5awZxpFTetNaji0Jq0S1qRRAo1mToW8ZcpD8pfho3loiLIjl9YPWqBZ0H6s3CznWaAbCptQWMRMDntNOzeF3GI2CouZZ237bkQxK8EErRLColVY9GZudeex4zFUNW_xVxn4cgtX1EVbuZVRfFsxC1MozkOzqOKaZcV2KxcnzsqQ3cjy41arrN26UY5EZtElyp1BFQ4t7XIkbxVmxMobsRpFld0oIbaX5lOtctahXTB_KZ6NFM2gSnJFq6zQUBqht5QWb9NFWTZZ0lK82UcKWlJpu4NZQqAog0ajLIFKi1r7hGTTSF6f4V1b5OCJ6Nh-xvyrSqFs64rOqrhV43szMk--iWLjhU8dHMRTYw-7q_g7H8ltmU7666KH4NN__iJBamWjbH_vLnUzp3F8ql0c6wh78Xf7fEpF7y0tmBLRXf-FDv7lDxxgZyLurfA7URNMZymOj0iaxIcE3uxkw69PidcTNJtKjJDMCf04E4dcwKA4qdu-5NSrJevdq-3-OZp_A7kjtso=

Before screenshot:

image

After screenshot:

image

Rename the skill name in `ModParser.lua` to match
the name specified in autogenerated files, this
enables `calcLib.getGameIdFromGemName` to return
it's intended value
@mart-mihkel
Copy link
Contributor Author

Might need to rebuild mod cache to see the changes

@sida-wang sida-wang added the bug: calculation Numerical differences label Feb 15, 2024
@sida-wang
Copy link
Contributor

Looks good to me. Can you include the updated ModCache file with the PR please?

@LocalIdentity LocalIdentity merged commit 19b2cfc into PathOfBuildingCommunity:dev Mar 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To Dust no longer reducing Skeleton duration
3 participants