Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting of ailment breakdown sections #7336

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Feb 2, 2024

Description of the problem being solved:

Adds conditional to breakdown sorting to only apply to sections that have a source so we avoid overwriting the sort of ailments done in CalcOffense.

Steps taken to verify a working solution:

  • Check ailment threshold breakdown for shock, chill, sap, brittle; verify sorted correctly
  • Verify effective dps mod for poison and ignite are unaffected
  • Roughly check other breakdowns with Base or Source columns to verify unchanged from live

Link to a build that showcases this PR:

eNrVHF2T2jjyOfkVLqruLQFs87k1s1sMzGSmaibhhklyey9bwhagjZBYW2bC_vpTS7YxDDI29j5cHhJj9be6W62WnKvffq6ptcVBSDi7btjNdsPCzOM-YcvrxteXu4-Dxm-_vr-aIrH6sriJCIWRX9-_u1LPFsVbTCVewxIoWGLxLaHk_iEpbRATK8zZE_qTB5-4f934zBluWHPEfCKSXx5FYfgZrfF14zsR3qphodDDzB_v399SvMZMIEpCIRFWKECewMEjcB9Fgj9xX0KJIJLk1oiwGfd-YPEp4NHmuuE0rC3Brxrm4Wn65fklIxphWdGkZu-uphTtcDATSFih_Ou6MZIGQkt8TyTzLaKRpGN3-k7TbQ8HdqOVi3QTBaGYoLV8LIE822Ds7-GbHWfQ7dvx3yakaYBvFwvsCbLF44CI8Qoxb8-1Z8IrC_sUUUE2lOAgI2HXhHH_hrjdbpuAX7ic5Ml0lsI6dtttOsNhP191jcf382PkIF1sdUOldS_g8rBkROAsojscus3ewB727XZ_4OQxfYvcaw97TekEveGw1xn2jdPKScjZAVe33exJ7DMYh07X69lN17EHeTKeYNXuDJrtTtdW7jc8Z_8samfoDqTj9t189cYRpTKnZDGNk_eMQxxskSCHQhrhx3w9J-xwrvvtjt3sO33bGTiObYzAJ8TQmId7j3LcPNApDmTOEgcY7TMIM-xxmeayKK7TzAR6EY6n6RhZP5IFLg5ZSqsYoaw0l-lxOysKV5rwZQI9y1grBjnjES0IKTIZtmMOir-ygD1jhE_wz2LksoBmcg8s67c55LKAdrdrFm_LIbLP20Vlm9v76Z59vzlwh4N-x-l1zcvjahcSD9En9JOso7Vcl17QD7xn1-2b3XS5EkwmKROqa1TqjgS4PNaYU_8CrBXioRGtlxeEBYwgSxLvF4B9YF6xyP7KApWvM5VMno0X-FnGG1RNc4oLYuxZxFFbpMjQrJaYxfx2xdR5xNhbfZLV5TMSuFiS32vRyzUrwBYyKwCeMmuvGEIJIwHiaSPlLpkljXTLcLDczVYEU78cdCLWGG0KJFIwcha7kLEP2ZXylyxqSZN8R4FfbLkpK9MWhdn0anfzzaXBi7kllhW1RPDxUanfNu9V-J-wU6Hl0EbBmkdBwQnXwIUUSNYGXTM_Yz_yii1FN1RuNYtKL6WitBTGSAjk_Zhwf4lLMSmFkW4aFeos2mxkvoC5L0oAFjlZmpNMTfOxVwD6i3TcQvEL62FxBnvowgzSFb44lyOU4rrAKl1CmT14YRbphD7J1ACNE9VOeOL--Rx-J3djhbZWCvBww2eOLv4qJV9BhygsBy2rmX0FYxQlwOzvXWH6B-CFGNwyPwogFArzOMY4xeaFrGXaDMMJEsjy4-L3GwoIYsJRPbUQo8BbPcqpv0OUzmUmuG5k36pfqtV1R6jAwUS-A6Yg2DFFO5n0q5Zq3cHTw3rDA2Hhn_DPFAVid91YIBpiDajeSDqhIEztuWU-orRhzVb8deRvgdML5zRMkCy02WDmH9B4CTC2UJJdPBBCKQ8_rDUKpdQ77a4haJPp_D34qnXHuBRAojl9d_ChOxgOBx_sXttxPzj9NrxxbfncaQ_s9odup9Ppf7CdTr8LVoK9Gwp2o0OSjEgNhJQq06qUW3vdhQQAVwn47urr86N6eLcSYhP-0mq9vr42N0is-AL_lOtW0-Pr1kYiSdU-hj8IpR-BbGsk_9wsn8Y3f96Pu-y_GxZ-nDCHv0avo5Ei3EooX-k2ZdjSvyC8AyK11e7RAhOp-QIbwsNnLnAIY_Ay-XE1A9ah9INAfMLr8GYnQ_IO6o6j9kc8CQA9w0L7VxYn6Z_6eIEiCu__HSFKwCfa2bePuuXLeLBO91KSlPQJWDk0xZfdBiZt9PioR0ZUxMSAXeIg2hFigSziJ84Rv1Sd3NFe6jGiXqjkJsyjkS83InG2Sh2QojnIBj1s2ET42Z5whlLK6N2VlCcG_kT5HFEnQYk7247UfYnX4BhPWCBfxmrrQUglWqBJS5GTT2mD-jtGP5gMaoh2FXeAeWJUOYxh7K-M3eNngJzoKWgcyGsn8h5p7PGI6UlmaB2HXsrKSnm16jXDt4gy2L8RkPnABEcjqfoTHG4QCf45pRMGcZBpUf9PvWwaBbqhm5o1fpOaM_79TxnzO9piiy-sMWdboivkN3aNH2VIq-Sl0xM8KssqiAe2iYQie91Yk9D7Yx4tFnA-IzURgTp6ur27ux2_PHy7jRfLLIrS9g8WredwAqH_hbVCQ86wEswKo3moH6X3EfyqBJlI6xIagnaUok2I09VK5Z9YcirxcqgpqHuSnuqcprUHMFO6_YkDubgu5Z7PCwg2ypWOnxFKM4T9IBQXJmpwTmImpLccY7k06_2qwVLqgMpMBc6JjOrAYA6uLEsQNXKOR89YQsAKJH2WLIgHdVn-lMN6paFy7OJ5sqTzdjnzHe-XzDTUwZOJgB40I-vDGRN2PJpjVXX-ZLSqHjWjT7CHjLrrQTNy2gLhTB2inqaSQuVQ-hyfa8mgGREKy5lxZuVyl4KYCX4RKxzEFaiJ0pPMUQlIbuAEZB4JcxhnIHJspdqxBgvBmBlVtxwNOsBYTiY6aMQZDJqFMZPSDSxjIstD1ftco_3iXXPOFMTtIYP59WiOEZIOmUH_eDgnSFT-HW058XXnxBAuR2B5CUNuEaqTUe2g6mSO-0PVKd7JXdcP43zHo2b0r0LVkyeo6BqmEBEIqmoUILaqUXg-LiT2uM_5JUTakjiJnIzmBX7cqbiYgu6nXIyu2j0XY6v0LetaLDXIzd8pTI57i4hNpDFEjmsXJKXEOp0H9tqVoqVXspOalqao4zM-H8wLYQ1yhpBciu9zir1ilNKW5T1GFC6icFqN4Jtz0Ep6chEi5k_gwKWionBeE20ksUSyL6eq9f2UHlO9aiX7KNVbg51N3BGciQA2pX9zvv5d7tvcYbc5aDv6Rdy0GcSNGlnqToi0eKA8JWEHgP-5bny0u8Nmx3GHfVf90WzVdjRuIsFz0kOKQqyvSXzHaMOZep1p78SgOWCHjR_KhSUL0fV0_vX5EdTRWz6NZcGuXOh9cjvZeZpQbjAV1mi-C0NELd1ps5wS-AnLYxrd8jScGmjY1uwVbY4J9WpQqFeDQmVo3HAZTccE3BIE7rHMhW_mtqpvXGSGU3PSrWFO7BpodEoapC6frCPIytBQxVUpq5_0QKei_7ilRS4zQZ8o3-KwipucjppeaQql1bQrq1lmbkfriGJRgwu6NaRFt7LqndLmLuPHz7J2uyRedeIrrVzVEO2WNkb1ZcWpTKG6DJ2qhuvUldvdUpL4O0v3XOrPW926Vmu7Ho2cqlNUuoKqnFp69WjerSyIWzZj2VWNbdeQ22uLqW4989CrWL9Ur0aqVlA1haJbV2qojdAlW4vLbFGXT9Y0FRfHSEVPqm11cGpIFHXQsOtSqLas9ZbQVStu9ujbbQHy8Uw1pr5juCoZ6u6V6iOp6wCcLcjyzeE-9IgItMpuGV7vxnCWjf0HdheoL2bmnFOMWNyxens1AAPSQ3jD1R2b-C7BlDCGPHoK_pDbV8bie_Xn-BikHIWrsrg3ARECTrvLoc08Li17gagrQml5tJsogKuupaWEG4FFmEWh4Osn7mdmzW63_wWf-jIPW4JbG3W-_X7k-6H0SPnCgX6pb_mqP_r-dx5ZHmJwBZHuLHjwtRzSY70oCPH7I3qhMqAFDkNw-GZUOrxhiLAFJZ6w5vHEnbOBPlkvbfHZCuLMgDalyMMrqT4Oso4ffzWc3IjpZ7_uOAV_cBU5wXLPIKX3npPrL-kFHKdjn-GX-dA4wermo2Svlqco59SSb8oLB5zKY6nG-h5h0DGCr9OvpuFLW8gXM3XRBq5ZzTBd7InY3fP6lbVJOmtTOAtJ57ogUukZAMc6NuZg2DuvVxnxYMbKwMcfd3BKnxHLStY_o05SWyXwPWcwLODqxwY4F1mHH6GU8cL04kLqQu2Dr4ePcEKyJPTLQp28SidUx8cpZnLKFC_PV63j__vhfxeVN2o=

Before screenshot:

image

After screenshot:

image

@Peechey Peechey added the bug: behaviour Behavioral differences label Feb 2, 2024
@LocalIdentity LocalIdentity merged commit 41eb129 into PathOfBuildingCommunity:dev Mar 9, 2024
2 checks passed
@Peechey Peechey deleted the fix/ailment_breakdown_sorting branch March 27, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants