Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when sorting gems on a disabled socket group #7317

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Jan 26, 2024

Fixes #7316

Description of the problem being solved:

Pre calculation of current main skill used incorrect env mode causing the wrong skill group to be selected inside of initEnv. This caused the main skill to be missing from player.activeSkillList causing the pre calculation to fail. This in turn caused a nil deref as this line:

if not GlobalCache.cachedData["CACHE"][triggeredUUID] then
calcs.buildActiveSkill(env, "CACHE", actor.mainSkill, {[triggeredUUID] = true})
end
local triggeredManaCost = GlobalCache.cachedData["CACHE"][triggeredUUID].Env.player.output.ManaCost or 0

assume that the calculation succeeded.

Steps taken to verify a working solution:

@QuickStick123 QuickStick123 added the crash Causes PoB to crash and is High Priority label Jan 26, 2024
@LocalIdentity LocalIdentity merged commit 2a2b454 into PathOfBuildingCommunity:dev Jan 26, 2024
2 checks passed
@LocalIdentity LocalIdentity changed the title Fix crash caused by incorrect calc mode used for manaforged source calc Fix crash when sorting gems on a disabled socket group Jan 26, 2024
@Paliak Paliak deleted the fix-7316 branch January 26, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Causes PoB to crash and is High Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message after removing a gem from a group (Forced Active) and trying to add a new one
3 participants