Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Powerful/Frenzied Faith displaying incorrect Id in the timeless jewel search #7251

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

sida-wang
Copy link
Contributor

@sida-wang sida-wang commented Jan 15, 2024

Fixes #7193 .

Description of the problem being solved:

Small internal error in AlternativePassiveSkills.dat which has the row Id swapped around for the Powerful Faith and Frenzied Faith. Created a bug report for it.

This PR adds handling to correct errors based on a manual list.

Note: actual exported file not committed in this PR.

Steps taken to verify a working solution:

  • Confirmed fix via export and checking the find timeless jewel function

Before screenshot:

  • Check linked issue
    image

After screenshot:

image
image

@sida-wang sida-wang added the bug: accuracy Wording differences label Jan 15, 2024
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the match table just in case you have duplicate IDs in the dat file? Unlikely, but technically possible, so that's fine. I think that'd cause problems elsewhere if it did happen, though.

@sida-wang
Copy link
Contributor Author

Yeah I'm not sure if the index column is unique but it was more for insurance in case the function is ever run twice on the row (maybe too extreme a possibility) - only an issue if you're replacing the Id field.

@Wires77 Wires77 merged commit 9208acf into PathOfBuildingCommunity:dev Jan 15, 2024
2 checks passed
@Wires77 Wires77 changed the title Fix Templar notables Powerful/Frenzied Faith displaying incorrect Id Fix Powerful/Frenzied Faith displaying incorrect Id in the timeless jewel search Jan 15, 2024
@sida-wang sida-wang deleted the issue-7193 branch January 20, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: accuracy Wording differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeless Jewel minimum power/frenzy charge display names are backwards
2 participants