Improve handling of trigger chance. #7244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Paliak
force-pushed
the
issue-7232
branch
2 times, most recently
from
10a981d to
45173b8
Compare
LocalIdentity
approved these changes
Jul 21, 2024
LocalIdentity
merged commit 0b8dd5e
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
|
This doesn't look to be working correctly... |
|
Right, self trigger skills. One sec... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7232 #7562.
Supersedes #6581.
Concludes #5428.
Description of the problem being solved:
Implements @sida-wang's formula improving handling of trigger chance application for trigger rates. Additionally changes the simulation slightly to make better use of each iteration. Effectively speeding it up by roughly 5x.
I was not able to get the simulation suggested in #6581 to work correctly so i ended up modifying the current one to speed it up slightly based on what i've learned from #6581, #5428 and #6492.
This could use outside testing.