Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirage cleanup #7239

Merged
merged 6 commits into from
Jan 21, 2024
Merged

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Jan 12, 2024

Fixes #6737.

Description of the problem being solved:

Cleans up handling of mirage skills. Applies various minor fixes.

Supersedes: #6753 Includes: #7238

Steps taken to verify a working solution:

  • Test mirage skills handled in CalcMirage.lua

@Paliak Paliak added enhancement New feature, calculation, or mod technical Hidden from release notes labels Jan 12, 2024
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved conflicts for you, but double check that commit to make sure it looks as expected.

@@ -183,8 +185,7 @@ function calcs.mirages(env)
local rateCapAdjusted
local triggerRateCap = m_huge
local SkillTriggerRate
local moreDamage = env.player.mainSkill.skillModList:Sum("BASE", env.player.mainSkill.skillCfg, "ChieftainMirageChieftainMoreDamage")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably stay so we don't break old trees unnecessarily.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't removed. I just moved it into the preCalcFunc since that's the only place it's used.

local moreDamage = env.player.mainSkill.skillModList:Sum("BASE", env.player.mainSkill.skillCfg, "ChieftainMirageChieftainMoreDamage")
-- Add new modifiers to new skill (which already has all the old skill's modifiers)
newSkill.skillModList:NewMod("Damage", "MORE", moreDamage, "Tawhoa's Chosen", env.player.mainSkill.ModFlags, env.player.mainSkill.KeywordFlags)

@LocalIdentity LocalIdentity merged commit ded89b8 into PathOfBuildingCommunity:dev Jan 21, 2024
@Paliak Paliak deleted the mirage-cleanup branch January 21, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod technical Hidden from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saviour got PointBlank Double Dip
3 participants