-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirage cleanup #7239
Mirage cleanup #7239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I resolved conflicts for you, but double check that commit to make sure it looks as expected.
@@ -183,8 +185,7 @@ function calcs.mirages(env) | |||
local rateCapAdjusted | |||
local triggerRateCap = m_huge | |||
local SkillTriggerRate | |||
local moreDamage = env.player.mainSkill.skillModList:Sum("BASE", env.player.mainSkill.skillCfg, "ChieftainMirageChieftainMoreDamage") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably stay so we don't break old trees unnecessarily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't removed. I just moved it into the preCalcFunc since that's the only place it's used.
PathOfBuilding/src/Modules/CalcMirages.lua
Lines 234 to 236 in ecd05e2
local moreDamage = env.player.mainSkill.skillModList:Sum("BASE", env.player.mainSkill.skillCfg, "ChieftainMirageChieftainMoreDamage") | |
-- Add new modifiers to new skill (which already has all the old skill's modifiers) | |
newSkill.skillModList:NewMod("Damage", "MORE", moreDamage, "Tawhoa's Chosen", env.player.mainSkill.ModFlags, env.player.mainSkill.KeywordFlags) |
Fixes #6737.
Description of the problem being solved:
Cleans up handling of mirage skills. Applies various minor fixes.
Supersedes: #6753 Includes: #7238
Steps taken to verify a working solution: