Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/maji double armour #7225

Merged

Conversation

Random-Panda
Copy link
Contributor

@Random-Panda Random-Panda commented Jan 10, 2024

Fixes #7184

Description of the problem being solved:

Oath of the Maji and Unbreakable did stack and armour from body armour would only be double a singled time instead of twice as happens in game.

Steps taken to verify a working solution:

  • Compared values given in the issue, expected (161,682), PoB (110,021) change are now reflect in game values
  • Compared armour values with only unbreakable or oath of the maji allocated. Expected armour values were seen
  • Compared armour values with neither oath or unbreakable allocated. Expected armour values were seen

Link to a build that showcases this PR:

https://pobb.in/KUg-NMqiDdx8

Before screenshot:

unbreakableBefore

After screenshot:

UnbreakableAfter

@sida-wang sida-wang added the bug: behaviour Behavioral differences label Jan 10, 2024
@LocalIdentity LocalIdentity merged commit 7861e6e into PathOfBuildingCommunity:dev Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oath of the Maji defence doubling does not stack with Unbreakable (Jugg)
5 participants