Add breakdown for Endurance, Frenzy and Power charges #7222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds some simple stats for the 3 base types of charges in the Calc tab: Max, Current, Spendable (max-min) and duration. It would be possible to add stats for all other possible charges, but it would take quite a bit of space, and it would not offer much useful information as apart from the `Charge Duration Mastery` and the `Swift Killer` ascendancy node, there isn't much affecting them.
Paliak
added
enhancement
LocalIdentity
approved these changes
Jan 12, 2024
LocalIdentity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some simple stats for the 3 base types of charges in the Calcs tab: Max, Current, Spendable (max-min) and duration.
It would be possible to add stats for all other possible charges, but it would take quite a bit of space, and it would not offer much useful information as apart from the
Charge Duration Masteryand theSwift Killerascendancy node, there isn't much affecting them.Description of the problem being solved:
Being able to see where the charges are coming, how many we have and their duration.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/3O7JAztbNxxR
After screenshot: