Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filtering on number of sockets and links in Item Trader #7217

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Jan 8, 2024

Fixes #6538

Description of the problem being solved:

Allow filtering trade queries on number of sockets and/or links. This sets both min and max so it's an exact number match. I added some checks to not show the controls for Flasks or Jewelry when applicable. There is the possibility to search for something with more links than sockets, which would return no results of course but I feel that's on the user not to break. Maybe some check could be added but I wasn't sure if it was worth it.

Pretty sure we could fairly easily update this to let users set min and max instead of hardcoding both if that's something we wanna do.

I also did some refactoring on how we are updating anchors and popup height.

Steps taken to verify a working solution:

  • Validate trade query filters generated matches the set socket and/or link number.
  • Validate socket only filtering and link only filtering works
  • Test socket and link input do not show for Flasks
  • Test link input does not show for Rings, Belts, or Amulets

After screenshot:

Body Armour:
image

Ring:
image

Flask:
image

@Peechey Peechey added the enhancement New feature, calculation, or mod label Jan 8, 2024
@Peechey Peechey changed the title Add filtering on number of sockets and links in Item Trader Add support for filtering on number of sockets and links in Item Trader Jan 9, 2024
@LocalIdentity LocalIdentity merged commit a5d6a84 into PathOfBuildingCommunity:dev Jan 12, 2024
@Peechey Peechey deleted the feature/trade_query_sockets_links branch July 17, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow filtering by max sockets in item trader
2 participants