Stop adding brand skill flags to skills triggered by arcanist brand #7188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might be revertable now? #4966 |
|
@QuickStick123 I'll add the revert here. Comparing by skill type should be nicer than a string match. |
This reverts commit ca25799.
LocalIdentity
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6323
Description of the problem being solved:
This seems to have been added in #1112 as a way of supporting Arcanist Brand with the old trigger calculations. It is no longer needed after the trigger rework has been merged and is causing the linked issue.
https://pobb.in/9-Ym5kqwpX15