Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where Precursor's Emblem's curse mod was not working #7186

Conversation

Drox346
Copy link
Contributor

@Drox346 Drox346 commented Dec 30, 2023

  • Splitting doActorMisc into doActorMisc and doActorCharges to enhance logic flow and increase performance. The separation allows for more granular execution, avoiding the need to run the entire functionality of the original doActorMisc function in all cases.
  • Calculate charges earlier to enable stats that depend on charge count.

Fixes #7172

Description of the problem being solved:

The mod "You can apply an additional Curse while at maximum Power Charges" did not function. The problem is that the charge related calculations got executed after the curse related calculations. Therefore charges were never set when curse related modifiers where calculated.

Steps taken to verify a working solution:

  • Compared multiple builds that use the bugged mod in question
  • Verified the impact on dps and if the additional curse is listed at the Calcs page
  • Compared all kinds of builds that use all kinds of charges to verify that no regression has occurred when splitting the doActorMisc function

Link to a build that showcases this PR:

https://pobb.in/hD5HjDv-gt82

Setup:

Gems
image

Precursor's Emblem with additional curse mod
image

Before screenshot:

image
image

After screenshot:

image
image

- Splitting doActorMisc into doActorMisc and doActorCharges to enhance logic flow and increase performance. The separation allows for more granular execution, avoiding the need to run the entire functionality of the original doActorMisc function in all cases.

- Calculate charges earlier to enable stats that depend on charge count.
@Paliak Paliak added enhancement New feature, calculation, or mod bug: behaviour Behavioral differences labels Dec 30, 2023
@Wires77 Wires77 merged commit 4e5bbd9 into PathOfBuildingCommunity:dev Jan 15, 2024
2 checks passed
@Wires77 Wires77 changed the title Fix: Precursor's Emblems curse mod does not work Fix bug where Precursor's Emblem's curse mod not working Jan 15, 2024
@Wires77 Wires77 changed the title Fix bug where Precursor's Emblem's curse mod not working Fix bug where Precursor's Emblem's curse mod was not working Jan 15, 2024
Copy link
Contributor

@sida-wang sida-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crud, didn't realise I needed to submit a review for it to show up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precursor's Emblems curse mod does not work
4 participants