Add new 3.23 Spectres #7127
Merged
Add new 3.23 Spectres #7127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
force-pushed
the
add_new-spectres
branch
from
099868e to
e988a08
Compare
LocalIdentity
force-pushed
the
add_new-spectres
branch
2 times, most recently
from
c16f01f to
33b6586
Compare
Co-authored-by: justjuangui <[email protected]>
Make the Fortiy buff from Naval Officer and Kingmaker automatically apply. Currently Kingmaker does not apply the Fortify buff at all from what I can tell Changes the behaviour of the "Are you Fortified" box to not set to maximum Fortification if you have a minimum Fortification value in the build
Changes some code in CalcActiveSkill to disregard the DualWieldOnly skilltype if it's on a Spectre Skill
LocalIdentity
force-pushed
the
add_new-spectres
branch
from
5268f50 to
e30e2a8
Compare
added 4 commits
January 22, 2024 14:55
We need more of the monster tags for other spectre buffs that only apply to Skeletons or Spiders and these are matched via the tags Switches the useage of MonsterCategory to MonsterTag Fix Hulking armour mod
Could not implement the default attack as it would crash PoB due to a stat interpolation issue Sap is also not showing up as a config option and I'm not sure what to change
The `NoExtraBleedDamageToMovingEnemy` condition is not working correctly an I'm not too sure why
Wither effect mod is not working correctly
Adds evasion multiplier to the Spectre tooltip
Cold Snap causes a crash due to the stat interpolation issue Fixes a bunch of skills that uses a version of firestorm Max shock effect mod does not work
Minimum shock mod is not applying atm
* Add support for minion aura debuffs * make it not stack with normal pride * fix issue with it not applying the debuffs stats * Does not affect allies --------- Co-authored-by: LocalIdentity <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on adding the new Spectres.
Curent Issues:
We don't support adding mods to the spectre mob itself, only its skill. We'd need this to more easily apply the bufffs some of the perfect mobs give. I had to give Perfect Dark Marionette another skill with the Scorch stat on it instead of just adding the scorch stat to the mob itself- Some of the skills are triggered and only have 1 value in granted effect with a stat interpolation value of 2 and CalcTools breaks when trying to find the previous levelAzmeriAdmiralDoubleStrikeTriggeredon Naval Officer is an example of thisWe don't currently export mob tags and this is needed for the buff from Hulking Miscreation to work. Tags are in CorpseTypeTags.dat and needs to be cross-referenced with MonsterVarieties.datThings to fix:
NoExtraBleedDamageToMovingEnemycondition is not workingMinion's to add