Fix The Adorned not applying to jewels in outer tree sockets #7086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for if the jewel came from the tree was coupled to the check to see if it was an expansion jewel so it didn't stop the jewel applying to Abyssal sockets on gear The only way I could see to get the jewel to apply to outer tree sockets was to make sure it didn't have a parent attribute in the expansionJewel attribute
|
Did you test this on medium cluster jewel sockets? |
|
@Wires77 I tested it on all sockets on Medium, large and Voices |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for if the jewel came from the tree was coupled to the check to see if it was an expansion jewel so it didn't stop the jewel applying to Abyssal sockets on gear
The only way I could see to get the jewel to apply to outer tree sockets was to make sure it didn't have a parent attribute in the expansionJewel attribute
Fixes #7079