Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lord of Drought increasing curse limit #7040

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Dec 15, 2023

Fixes #6991 .

Description of the problem being solved:

Some mods cause certain curses to ignore whether an enemy is hexproof or not. Currently the mod uses the ignoreHexLimit skillData flag which incorrectly causes the affected curses to ignore curse limit.

Additionally refactors triggerExtraSkill to use an options table instead of positional arguments.

Steps taken to verify a working solution:

  • Build from issue
  • curse enemies with level 10 Despair on Hit, which can apply to hexproof enemies

@Paliak Paliak changed the title Implements ignoresHexproof Implement ignoresHexproof Dec 15, 2023
@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Dec 16, 2023
@LocalIdentity LocalIdentity changed the title Implement ignoresHexproof Fix Lord of Drought increasing curse limit Dec 16, 2023
@LocalIdentity LocalIdentity merged commit 2a27a96 into PathOfBuildingCommunity:dev Dec 16, 2023
@Paliak Paliak deleted the issue-6991 branch January 20, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For some odd reason i can have 2 curses (Flammability + Elemental weakness) on at the same time?
2 participants