Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidden blade not using main weapon and its supports #7038

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Dec 15, 2023

Fixes #6966

Description of the problem being solved:

According to the wiki Unseen Strike will only use the main hand weapon and the supports socketed in that weapon regardless of which slot it's in.

The fixes causes a small visual inconsistency in the source of the custom group for the skill as it will show as socketed in "Weapon 1" regardless of the actual socketed slot. Fixing this would require relatively significant changes to the group slot logic.

Steps taken to verify a working solution:

  • Tested build from issue
  • Tested Hidden blade in both slots

@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Dec 16, 2023
@LocalIdentity LocalIdentity merged commit 2646e33 into PathOfBuildingCommunity:dev Dec 16, 2023
@Paliak Paliak deleted the issue-6966 branch January 20, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unseen strike use average of both hand instead of primary weapon
2 participants