Fix Rigwald's Curse damage conversion with specific claw mods #7037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7036
Description of the problem being solved:
Rigwald's Curse damage conversion was looking specifically for ModFlag Claw. However, claw damage mods such as "with claws" create a ModFlag of Claw, Hit with no KeywordFlag, whereas something like "Claw Attacks deal increased..." mods create a ModFlag of Claw and KeywordFlag of Hit.
So this PR has the damage conversion check for ModFlag of Claw, Hit instead, which I assume is safe because the CritChance conversion below it does the same thing at line 595. Although I wonder if this should also add the Attack flag as well, like attack speed does? Unsure if it needs it.
Link to a build that showcases this PR:
Before screenshot:
After screenshot: