Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated import code with extra data GGG kindly provided #6987

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Updated import code with extra data GGG kindly provided #6987

merged 1 commit into from
Dec 11, 2023

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Dec 11, 2023

Fixes # .

Description of the problem being solved:

Before, GGG didn't supply ascendancy IDs in their unofficial API. Novynn was kind enough to supply these for us, so this PR switches to use them.

Steps taken to verify a working solution:

  • Imported character to empty build
  • Imported a different character over an existing build
  • Imported a new character on an old build

@LocalIdentity LocalIdentity merged commit 48ca3d9 into PathOfBuildingCommunity:dev Dec 11, 2023
@Wires77 Wires77 mentioned this pull request Dec 11, 2023
Merged
@Wires77 Wires77 deleted the update_import_API branch July 29, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wires77 @LocalIdentity