Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save trade search weights to build xml #6954

Merged

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Dec 7, 2023

Description of the problem being solved:

Saw a couple comments about this over the past few days so I took a crack at it. This saves the search weights to the xml under the Items node with a new element called "TradeSearchWeights". The default Full DPS and Effective Hit Pool still load on new builds or builds without this element, but any build that adjusts these weights should have them loaded as set from then on.

Open to suggestions on elem wording and xml structure.

After screenshot:

image

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Dec 7, 2023
@Wires77 Wires77 merged commit 1bc163f into PathOfBuildingCommunity:dev Dec 11, 2023
@Peechey Peechey deleted the feature/save_trade_stat_weights branch December 12, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants