Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra damage taken mod from bear trap not ending up in enemyDB #6900

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Fix extra damage taken mod from bear trap not ending up in enemyDB #6900

merged 1 commit into from
Dec 4, 2023

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Dec 4, 2023

Fixes #6892

Description of the problem being solved:

The extra damage mod from bear trap didn't end up in the enemyDB and was thus not counted.

Steps taken to verify a working solution:

  • Test build from issue

@Paliak Paliak added the bug: calculation Numerical differences label Dec 4, 2023
@LocalIdentity LocalIdentity merged commit 4145257 into PathOfBuildingCommunity:dev Dec 4, 2023
@Wires77 Wires77 mentioned this pull request Dec 11, 2023
Merged
@Paliak Paliak deleted the issue-6892 branch January 20, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees
No one assigned
Labels
bug: calculation Numerical differences
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bear Trap "Damage Taken" debuff doesn't appear in "Effective DPS Mod" breakdown
2 participants
@Paliak @LocalIdentity