Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fullDPS not working with two part skills #6899

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Dec 4, 2023

Fixes #6857

Description of the problem being solved:

if activeSkill.activeEffect.grantedEffect == gemData.gemData.grantedEffect then
return gemData.count or 1, true
end

Does not take into account the case when the active skill comes from the secondary part of a gem like is the case for Flamewood causing the fullDPS count to be ignored.

Steps taken to verify a working solution:

  • Tested build from issue

@Paliak Paliak added bug: calculation Numerical differences bug: behaviour Behavioral differences labels Dec 4, 2023
@LocalIdentity LocalIdentity merged commit 984d35f into PathOfBuildingCommunity:dev Dec 4, 2023
@Paliak Paliak deleted the issue-6857 branch January 20, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Count does not affect Flamewood support Full DPS
2 participants