-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Eldritch Battery interaction with Mind over Matter and Energy Shield bypass #6869
base: dev
Are you sure you want to change the base?
Conversation
Fix using wrong damageTable to calc PoolsLost
https://www.reddit.com/r/pathofexile/comments/18c430i/pob_says_the_top_mastery_still_works_is_pob_wrong/ |
While similar, the issue is located in the parsing, and so is not touched by the code in this PR. I've created a new PR 6965 to solve the above issue. |
Fixes #6797. Built on top of #6729 and #6770, so those should be merged first.
Description of the problem being solved:
When a build had both Mind over Matter and Eldritch Battery, energy shield bypass would not function correctly for calculating max hit. The calculation is changed to added EHP from MoM in two parts: one with both mana+es, and one with only es at reduced mitigation.
The second part is important for when damage can bypass es, as this might create a scenario where a build has no mana left after taking damage, but still has es protecting mana. This is essentially a new weaker shield, that protects the life remaining after taking enough damage to fully drain mana.
I have changed the Mind over Matter breakdown for when this case occurs, and I am open for suggestions to improve the breakdown.
Since the PR expands on #6770, some behavior of ES, MoM and Ward has been moved into class-like tables in
CalcHitPools.lua
. Ward is not related to the bug-fix, but was already in the works when I started to solve the bug.Steps taken to verify a working solution:
Link to a build that showcases this PR:
Build from #6797 with Mind of the Council:
Build from #5549
Build with 70% Chaos ES Bypass
Build with ward and Olroth's Resolve
Before screenshot:
Max Hit Breakdown:
Mind over Matter Breakdown:
After screenshot:
Max Hit Breakdown:
Mind over Matter Breakdown (simple, excess mana + es):
Mind over Matter Breakdown (simple, bottlenecked by mana + es)
Mind over Matter Breakdown (complex due to es bypass)