Fix Phantasmal Flameblast AoE values #6813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phantasmal Flameblast grants base radius to the gem as its quality effect. It used the `active_skill_base_radius_+` stat to grant the extra base radius which was stat mapped to `skill("radiusExtra", nil)`.
This would be overwritten by the stat map on the gem that also used `radiusExtra` instead of summing the values together. Changed the statMap on the gem to use `mod("AreaOfEffect", "BASE")` instead so it sums correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phantasmal Flameblast grants base radius to the gem as its quality effect. It used the
active_skill_base_radius_+stat to grant the extra base radius which was stat mapped toskill("radiusExtra", nil).This would be overwritten by the stat map on the gem that also used
radiusExtrainstead of summing the values together. Changed the statMap on the gem to usemod("AreaOfEffect", "BASE")instead so it sums correctly