Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursive EnemyMods Party struct #6800

Merged

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Oct 9, 2023

Fixes #6799

Description of the problem being solved:

The changed section of code currently creates a sort of a nested tree of mods instead of a list. ModTools funcs don't have the ability to process this kind of structure correctly causing a crash in many cases.

Steps taken to verify a working solution:

  • Test that the build from the issue works correctly

Link to a build that showcases this PR:

https://pobb.in/XQsAYJ86QMMN

@Paliak Paliak marked this pull request as ready for review October 10, 2023 00:23
@Paliak Paliak added the bug: calculation Numerical differences label Oct 27, 2023
@LocalIdentity LocalIdentity merged commit 6f6bf56 into PathOfBuildingCommunity:dev Dec 1, 2023
@Paliak Paliak deleted the fixRecursiveEnemyMods branch January 20, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The build has been loaded, but cannot be saved.
2 participants